chore: moved tests from test_utils to test_params, and well fixed a b…#20
Merged
eschmidt42 merged 1 commit intomainfrom Aug 17, 2025
Merged
chore: moved tests from test_utils to test_params, and well fixed a b…#20eschmidt42 merged 1 commit intomainfrom
eschmidt42 merged 1 commit intomainfrom
Conversation
…unch of other things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors imports and type references throughout the codebase to simplify and standardize the usage of parameters and utility functions. It also moves the
bool_to_floatutility function to a more appropriate location and updates related tests accordingly. No core logic is changed, but the codebase is now cleaner, with improved maintainability and clarity.Refactoring and Simplification of Imports and Type References:
random_tree_models.params.MetricNames) with direct imports and usage throughoutestimators.pyandsplit.py, making the code more concise and readable. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Utility Function Relocation:
bool_to_floatfunction fromgradientboostedtrees.pytoutils.py, and updated all usages and imports accordingly. [1] [2] [3]Test Updates and Cleanup:
test_bool_to_floattest, as the function is now a generic utility.…unch of other things