Added ability to get listeners for a specific hook #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add ability to retrieve a list of listeners for a specific hook:
$fooListeners = Hook::getListeners('fooHook');Why?
We wanted to use hooks to filter an array of values. This is difficult because Hook calls the default internal function in both of these circumstances:
If no listeners were executed, we want the array to be unfiltered. If listeners were executed and they removed all values from the array, we want the array to be empty. Therefore, we want a different result in each circumstance, but the internal function does not "know" which circumstance has occurred.
The easiest solution is to check whether any listeners have been registered, and then skip the hook entirely if there are no listeners.
Currently this can be done by calling Hook::getListeners() but then the caller needs to do some logic to check whether the relevant array key has been set. It seems neater if getListeners() can take a hook name and then just return the listeners which are registered for that hook.