chore: Improve repository cleanup and artifact management#16
Merged
eshaffer321 merged 1 commit intomainfrom Oct 23, 2025
Merged
chore: Improve repository cleanup and artifact management#16eshaffer321 merged 1 commit intomainfrom
eshaffer321 merged 1 commit intomainfrom
Conversation
Changes: - Enhanced Makefile clean target to remove all build artifacts - Added removal of coverage.txt (root coverage file) - Added removal of mcp-monarch binaries (root and cmd/mcp-server) - Added removal of test_*.go files (ad-hoc test files) - Added removal of security-report.json (from make security) - Added removal of *.bak files (backup files) - Removed redundant cmd/mcp-server/.gitignore - Root .gitignore already covers mcp-monarch binary - Subdirectory .gitignore had wrong binary name (monarch-mcp-server vs mcp-monarch) Why this matters: - make clean now properly removes ALL artifacts, not just bin/ directory - Prevents confusion about why artifacts remain after running make clean - Ensures consistent cleanup across local development environments Testing: - All tests pass (51/51) - make clean successfully removes all artifacts
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (43.18%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 43.18% 43.18%
=======================================
Files 15 15
Lines 2239 2239
=======================================
Hits 967 967
Misses 1198 1198
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
make cleantarget to properly remove ALL build artifacts, not just thebin/directory. It also removes a redundant.gitignorefile in the mcp-server directory.Changes Made
Enhanced Makefile clean target
coverage.txt(root coverage file)mcp-monarchbinaries (root andcmd/mcp-server/)test_*.gofiles (ad-hoc test files)security-report.json(frommake security)*.bakfiles (backup files)Cleanup
cmd/mcp-server/.gitignore.gitignorealready coversmcp-monarchbinary.gitignorehad wrong binary name (monarch-mcp-servervsmcp-monarch)Why This Matters
Before this PR: Running
make cleanwould only remove thebin/directory andcoverage.out/coverage.htmlfiles, leaving behind:coverage.txt(36KB)mcp-monarchbinary (11MB)test_*.gofiles*.bakbackup filessecurity-report.jsonAfter this PR:
make cleanremoves ALL artifacts consistently.Testing
make cleansuccessfully removes all artifactsNotes
This addresses the issue where
make cleandidn't removecoverage.txtand other artifacts that were left in the working directory. The.gitignorewas already correctly configured to ignore these files - we just needed thecleantarget to remove them properly.