Skip to content

Create requirements.txt#46

Open
demitri wants to merge 2 commits intoesheldon:masterfrom
demitri:master
Open

Create requirements.txt#46
demitri wants to merge 2 commits intoesheldon:masterfrom
demitri:master

Conversation

@demitri
Copy link

@demitri demitri commented Apr 1, 2020

Adding a requirements.txt file to help determine package dependencies.

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be missing joblib here. I need to double check.

Adding missing `joblib` package.
@demitri
Copy link
Author

demitri commented Apr 2, 2020

Good catch; updated.

@beckermr
Copy link
Collaborator

beckermr commented Apr 2, 2020

@esheldon anything to add here?

@beckermr
Copy link
Collaborator

beckermr commented Apr 2, 2020

Is esutil used?

@esheldon
Copy link
Owner

is this ready?

@beckermr
Copy link
Collaborator

I asked about esutil. Maybe we should compare to the conda package?

@esheldon
Copy link
Owner

@esheldon
Copy link
Owner

that only lists

    - numpy
    - fitsio
    - pyyaml
    - esutil

is that incomplete?

@esheldon
Copy link
Owner

and I don't even see yaml used in the meds repo

@beckermr
Copy link
Collaborator

it probably is incomplete

@esheldon
Copy link
Owner

OK. I'm working on some unit tests today. I'll add a requirements that is correct as well. We can update the meds feedstock based on that.

@esheldon
Copy link
Owner

I added a requirements.txt in this PR #51

@esheldon
Copy link
Owner

biggles is no longer supported, planning to move the meds-view code to matplotlib at some point

@esheldon
Copy link
Owner

I merged #51 which added a requirements.txt

It only has the things needed for the current tests. We will need more things once the other codes are rewritten, e.g. the meds viewer code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants