Open
Conversation
ce48643 to
4f87f82
Compare
4f87f82 to
9ef48fd
Compare
9ef48fd to
8fff2cd
Compare
Open
58d91af to
f01e89e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current caching strategies are undefined. We use caching for both storing authentication nonces and for systems that use a single feed for more than one network within the system.
This PR tries to add a configurable layer for caching that is completely user defined. Any configuration that we would explicitly provide and hardcode would not be suitable for all uses of this library. In the cases where it makes sense to hardcode it (auth), it is providen by a new
cache_forargument toscraper.request.The configuration layer is provided as a list of hashes that are defined using regex syntax. Rules follow this pattern:
module::tag::method::url. This is a sample configurationI have yet not decided if I want to include a set of defaults or not. Probably yes