feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 #232
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
requested changes
Oct 10, 2025
There was a problem hiding this comment.
Could we also update the Node.js engine versions in plugin/templates/_package.json as well?
generator-eslint/plugin/templates/_package.json
Lines 35 to 37 in 79641d3
Or is it intentionally missing?
lumirlumir
previously approved these changes
Oct 11, 2025
1 task
aladdin-add
force-pushed
the
feat/drop-node-18
branch
from
92b3d2a to
146b4c5
Compare
MikeMcC399
reviewed
Oct 18, 2025
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
lumirlumir
requested changes
Oct 19, 2025
Co-authored-by: 루밀LuMir <rpfos@naver.com>
lumirlumir
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updated package.json of the package to require:
"node": "^20.19.0 || ^22.13.0 || >=24"
This drops support for Node.js 18.
What changes did you make? (Give an overview)
Related Issues
refs eslint/eslint#19969
fixes #231
Is there anything you'd like reviewers to focus on?