fix(cmake): remove redundant OpenMP compile flags in non-Homebrew path#234
Merged
esmuellert merged 2 commits intoesmuellert:mainfrom Feb 11, 2026
Merged
Conversation
On newer CMake (4.x+), find_package(OpenMP) succeeds on macOS,
bypassing the Homebrew fallback. In the standard path,
target_compile_options added ${OpenMP_C_FLAGS} as a single quoted
argument ("-Xclang -fopenmp"), which clang rejects. This was
redundant since OpenMP::OpenMP_C already propagates compile flags
via INTERFACE properties.
Move target_compile_options into the HOMEBREW_OPENMP branch where
it's actually needed, and remove it from the standard path.
This was referenced Feb 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_compile_optionsfor OpenMP in the standard (non-Homebrew) CMake pathtarget_compile_optionsinto theHOMEBREW_OPENMPbranch where it's actually neededWhy
On newer CMake (4.x+),
find_package(OpenMP)succeeds on macOS, bypassing the Homebrew fallback. In the standard path,target_compile_optionsadded${OpenMP_C_FLAGS}as a single quoted argument ("-Xclang -fopenmp"), which clang rejects. This was redundant sinceOpenMP::OpenMP_Calready propagates compile flags viaINTERFACE_COMPILE_OPTIONS.Test plan
Resolves: #237.