Fix Fix() and Remove(); improve tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than relying on Seed(0), try things in a different order every time. The seed is logged so that if something fails, the problem can be reproduced using the -seed flag.
Removes elements from a larger minmax heap in a random order, making sure all elements were yielded and no non-elements were yielded.
This can be used when a test fails unexpectedly to show the structure of the tree and where values are. Perhaps this is overkill, but I found it very useful.
This now checks that grandchildren have the correct relationship to nodes. Without this, it was possible for an invalid tree to pass verify().
This appears to fix all of the ordering problems I have been experiencing so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug causing minmax heap invariants to be violated in certain conditions when using Remove() or Fix().
I also added a lot to the test suite to aid in debugging and visualizing the problem.