Add win-arm64 platform support to tools schema#103
Merged
ivmarkov merged 1 commit intoesp-rs:masterfrom Mar 28, 2026
Merged
Conversation
The ESP-IDF tools.json manifest added a win-arm64 platform variant for Windows ARM64. Add it to PlatformOverrideInfoPlatformsItem enum, VersionInfo struct, and the OS matcher in parse_tools to prevent panics when parsing manifests that include this platform. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
You'll have to then temporarily |
Contributor
Author
Yeah, maybe this one is not too critical and can wait for a release... CIEspIdfNext has been red for a long time. |
Collaborator
True, but no big deal to also add embuild to the patch section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
The ESP-IDF tools.json manifest added a win-arm64 platform variant for Windows ARM64. Add it to PlatformOverrideInfoPlatformsItem enum, VersionInfo struct, and the OS matcher in parse_tools to prevent panics when parsing manifests that include this platform.
Testing
Spotted on the idf-next CI for esp-idf-hal (https://github.com/esp-rs/esp-idf-hal/actions/runs/23682870831/job/68997591274). It's aleady a problem on
release/v6.0(not justmaster), so probably worth having already.