Skip to content

build: add ESP_IDF_SYS_EXTRA_COMPONENTS_FILE env var support#411

Merged
ivmarkov merged 1 commit intoesp-rs:masterfrom
drinkcat:comp-from-env
Mar 29, 2026
Merged

build: add ESP_IDF_SYS_EXTRA_COMPONENTS_FILE env var support#411
ivmarkov merged 1 commit intoesp-rs:masterfrom
drinkcat:comp-from-env

Conversation

@drinkcat
Copy link
Copy Markdown
Contributor

@drinkcat drinkcat commented Mar 28, 2026

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

Allows specifying extra_components via one or more comma-separated TOML files, useful for CI to conditionally enable components (e.g. remote components moved out of the esp-idf tree in v6.0) without modifying Cargo.toml.

When set, takes precedence over the root crate's Cargo.toml extra_components, but extra_components from direct dependencies are still merged in.

Testing

Usecase: esp-rs/esp-idf-svc#652

Allows specifying extra_components via one or more comma-separated TOML
files, useful for CI to conditionally enable components (e.g. remote
components moved out of the esp-idf tree in v6.0) without modifying
Cargo.toml.

When set, takes precedence over the root crate's Cargo.toml
extra_components, but extra_components from direct dependencies are
still merged in.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ivmarkov
Copy link
Copy Markdown
Collaborator

I would never rely on an env var for specifying dependencies, but since this is explicitly documented as useful "in CI", I'm actually fine with the approach!

@ivmarkov ivmarkov merged commit da6658f into esp-rs:master Mar 29, 2026
46 of 48 checks passed
@drinkcat drinkcat deleted the comp-from-env branch March 29, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants