build: add ESP_IDF_SYS_EXTRA_COMPONENTS_FILE env var support#411
Merged
ivmarkov merged 1 commit intoesp-rs:masterfrom Mar 29, 2026
Merged
build: add ESP_IDF_SYS_EXTRA_COMPONENTS_FILE env var support#411ivmarkov merged 1 commit intoesp-rs:masterfrom
ivmarkov merged 1 commit intoesp-rs:masterfrom
Conversation
Allows specifying extra_components via one or more comma-separated TOML files, useful for CI to conditionally enable components (e.g. remote components moved out of the esp-idf tree in v6.0) without modifying Cargo.toml. When set, takes precedence over the root crate's Cargo.toml extra_components, but extra_components from direct dependencies are still merged in. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
Collaborator
|
I would never rely on an env var for specifying dependencies, but since this is explicitly documented as useful "in CI", I'm actually fine with the approach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
Allows specifying extra_components via one or more comma-separated TOML files, useful for CI to conditionally enable components (e.g. remote components moved out of the esp-idf tree in v6.0) without modifying Cargo.toml.
When set, takes precedence over the root crate's Cargo.toml extra_components, but extra_components from direct dependencies are still merged in.
Testing
Usecase: esp-rs/esp-idf-svc#652