Skip to content

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This pull request enhances the release workflow to support the handling and distribution of esp-hosted binaries. It introduces steps to copy these binaries during the release process, uploads them as build artifacts, and then commits them to the gh-pages branch for distribution. The main changes are grouped below:

Release Script and Artifact Handling:

  • Updated .github/scripts/on-release.sh to copy esp-hosted .bin files from the build output to a new hosted directory in the workspace, preparing them for upload.
  • Modified .github/workflows/release.yml to upload the hosted binaries as a build artifact after the main release script runs.

Distribution via GitHub Pages:

  • Added a new upload-hosted-binaries job to the workflow that:
    • Checks out the gh-pages branch.
    • Downloads the hosted binaries artifact.
    • Copies new binaries to the appropriate directory without overwriting existing files.
    • Commits and pushes any new binaries to gh-pages, making them available for distribution.

@lucasssvaz lucasssvaz requested a review from me-no-dev October 27, 2025 19:04
@lucasssvaz lucasssvaz self-assigned this Oct 27, 2025
@lucasssvaz lucasssvaz added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Oct 27, 2025
@github-actions
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 00605a9

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants