Skip to content

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Nov 4, 2025

Description of Change

This is a Enhanced Color Light example using Thread over Matter with Arduino Matter Library code.
The example shall be built using Arduino as IDF Component.

Test Scenarios

Using ESP32-C6, build the example and use some Matter Environment to commission the C6 Light.

Related links

closes #11820
#11777

This is a Enhanced Color Light example using Thread over Matter with Arduino Matter Library code.
The example shall be built using Arduino as IDF Component.
@SuGlider SuGlider added this to the 3.4.0 milestone Nov 4, 2025
@SuGlider SuGlider self-assigned this Nov 4, 2025
@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Nov 4, 2025
@SuGlider SuGlider moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Nov 4, 2025
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(matter): Revise README for ESP32-C5, C6, and H2 support":
    • body's lines must not be longer than 100 characters
  • the commit message "fix(matter): typo":
    • summary looks too short
  • the commit message "fix(matter): typo":
    • summary looks too short
  • the commit message "fix(matter): typo":
    • summary looks too short
  • the commit message "fix(matter): typos":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 949b4ed

@SuGlider SuGlider requested a review from Copilot November 4, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Arduino ESP-Matter over Thread example for ESP32-C6, demonstrating how to build a Matter-enabled RGB light that operates exclusively over Thread (without Wi-Fi). The example showcases integration of Arduino Core with ESP-Matter using an Enhanced Color Light endpoint.

Key changes:

  • Introduces a complete Matter-over-Thread RGB light implementation using Arduino APIs
  • Configures Thread-only connectivity (Wi-Fi disabled) with OpenThread and BLE for commissioning
  • Implements persistent state storage using Preferences library for OnOff and HSV color states

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sdkconfig.defaults Configures ESP32-C6 for Thread-only operation with Matter support, disabling Wi-Fi and enabling OpenThread
partitions.csv Defines custom partition table with OTA support, encrypted NVS, and factory partitions
idf_component.yml Specifies dependencies for ESP-Matter (>=1.3.0) and Arduino-ESP32 (>=3.0.5)
MatterEnhancedColorLight.cpp Main application implementing RGB color light with button control and Matter integration
CMakeLists.txt Top-level build configuration with C++20 and Matter-specific compiler flags
main/CMakeLists.txt Component-level build configuration
README.md Documentation with setup instructions and usage guidelines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SuGlider and others added 3 commits November 4, 2025 06:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SuGlider and others added 2 commits November 4, 2025 06:26
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@me-no-dev
Copy link
Member

@SuGlider should this go into 3.3.3 or wait for 3.4.0?

Comment on lines 1 to 11
targets:
esp32s2: false
esp32s3: false
esp32c2: false
esp32c3: false
esp32p4: false

requires:
- CONFIG_OPENTHREAD_ENABLED=y
- CONFIG_ESP_MATTER_ENABLE_DATA_MODEL=y
- CONFIG_MBEDTLS_HKDF_C=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid having to edit this list everytime a new SoC is released you can add the SoC config to the requirements:

Suggested change
targets:
esp32s2: false
esp32s3: false
esp32c2: false
esp32c3: false
esp32p4: false
requires:
- CONFIG_OPENTHREAD_ENABLED=y
- CONFIG_ESP_MATTER_ENABLE_DATA_MODEL=y
- CONFIG_MBEDTLS_HKDF_C=y
requires:
- CONFIG_IDF_TARGET_ESP32C6=y
- CONFIG_OPENTHREAD_ENABLED=y
- CONFIG_ESP_MATTER_ENABLE_DATA_MODEL=y
- CONFIG_MBEDTLS_HKDF_C=y

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it could run wihtin the ESP32C5 and ESP32H2 too.
Maybe just

  - CONFIG_OPENTHREAD_ENABLED=y
  - CONFIG_ESP_MATTER_ENABLE_DATA_MODEL=y
  - CONFIG_MBEDTLS_HKDF_C=y

Shall be enough.
I can remove the TARGET=C6 in sdkconfig to get it open for any OPENTHREAD compatible device.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove the targets: clause, it fails CI with different errors with S2, S3, P4 and C2.
Passes ESP32 and C3 (plus C5, C6 and H2.
Errors are related to BT, I2S IDF Component within ESP-SR and CHIP (matter) with C2 + IDF 5.5

@SuGlider SuGlider modified the milestones: 3.4.0, 3.3.0 Nov 5, 2025
@SuGlider
Copy link
Collaborator Author

SuGlider commented Nov 5, 2025

@SuGlider should this go into 3.3.3 or wait for 3.4.0?

3.3.3 is better. I was not sure if we eould realease a 3.3.x version before 3.4.0

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 5, 2025
@github-actions github-actions bot added the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋 View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions github-actions bot removed the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Matter Over Thread on ESP 32 C6

5 participants