feat(led_strip): support led strip group based on parlio_tx#463
Open
Kainarx wants to merge 6 commits intoespressif:masterfrom
Open
feat(led_strip): support led strip group based on parlio_tx#463Kainarx wants to merge 6 commits intoespressif:masterfrom
Kainarx wants to merge 6 commits intoespressif:masterfrom
Conversation
fcbb89b to
8a3c225
Compare
ba13628 to
5ce030e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for LED strip groups using the Parallel IO (PARLIO) backend while also adding an asynchronous refresh API and runtime GPIO switching for the RMT backend. Key changes include:
- Adding new group APIs (led_strip_group_get_strip_handle and led_strip_group_del) and the corresponding type definitions.
- Integrating the PARLIO backend by adding led_strip_parlio_config_t and led_strip_new_parlio_group.
- Updating documentation, examples, version numbers, and build configuration files.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| led_strip/src/led_strip_api.c | Added new API implementations for led strip group and GPIO switching. |
| led_strip/interface/led_strip_interface.h | Declared new group interface and added async refresh API documentation. |
| led_strip/include/led_strip_types.h | Introduced led_strip_group_handle_t and encoder timings structures. |
| led_strip/include/led_strip_spi.h | Updated SPI configuration to use a named extra config structure. |
| led_strip/include/led_strip_parlio.h | Added Parallel IO backend specific configurations and API declaration. |
| led_strip/include/led_strip.h | Declared group APIs and updated documentation for async refresh and GPIO. |
| led_strip/idf_component.yml | Bumped component version to 3.1.0 and updated metadata. |
| led_strip/examples/* | Added or updated examples and tests for PARLIO, SPI, and RMT backends. |
| led_strip/api.md | Updated API documentation to include new group and async refresh APIs. |
| led_strip/CMakeLists.txt & .build-test-rules.yml | Adjusted build configuration and test rules for PARLIO support. |
| led_strip/CHANGELOG.md | Documented new features and changes for version 3.1.0. |
Comments suppressed due to low confidence (2)
led_strip/interface/led_strip_interface.h:140
- Typo in parameter description: 'Retured' should be corrected to 'Returned'.
* @param ret_strip: Retured LED strip handle
led_strip/api.md:681
- Typo in the documentation: 'Retured' should be 'Returned'.
- `ret_strip` Retured LED strip handle
454123f to
4c303b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427