feat(swift): initiall commit (IEC-489)#685
Conversation
suda-morris
left a comment
There was a problem hiding this comment.
Nice!
Is it possible to have a test app and CI test to ensure the basic interoperation between Swift-lang and C? Maybe there is an existing GitHub action we can utilize to set up the Swift dev environment.
ef04045 to
a781d7b
Compare
|
@suda-morris , added test app, PTAL |
| pip install --upgrade 'idf-build-apps~=2.12' | ||
| if [ "$SWIFT_ENABLED" = "true" ]; then | ||
| echo "fetching swift version" | ||
| curl -sL https://raw.githubusercontent.com/swiftlang/swift-embedded-examples/main/.swift-version -o .swift-version |
There was a problem hiding this comment.
can we put the .swift-version under the application project instead of under the repo root?
There was a problem hiding this comment.
It can't install swift in case the file has custom path
| runs-on: ubuntu-22.04 | ||
| container: espressif/idf:${{ matrix.idf_ver }} | ||
| env: | ||
| SWIFT_ENABLED: ${{ !contains(fromJSON('["release-v5.1","release-v5.2","release-v5.3"]'), matrix.idf_ver) }} |
There was a problem hiding this comment.
maybe we can create a dedicated CI job for swift applications and leave this build job as a generic job?
There was a problem hiding this comment.
@suda-morris , I'm not sure this can be achieved gracefully, maybe better solution is to move to a separate repo
There was a problem hiding this comment.
I would suggest a separate repo, as well.
Copied with refactoring from https://github.com/swiftlang/swift-embedded-examples Co-authored-by: Erhan Kurubas <erhan.kurubas@espressif.com>
| - sh2lib | ||
| - spi_nand_flash | ||
| - supertinycron | ||
| - swift |
There was a problem hiding this comment.
How about swift_support or swift_embedded? We might have other swift-related components in the future, so it would be nice to give a hint at the purpose of the component.
|
moved to espressif/esp-swift#1 |
Checklist
urlfield definedChange description
Copied with refactoring from https://github.com/swiftlang/swift-embedded-examples