Conversation
The README examples have been updated to reflect the accurate zmanim times calculated using the Astral library. Astral provides more precise calculations for sunrise, sunset, and other zmanim, ensuring that the examples showcase the true capabilities of JewCal.
This commit refines the handling of zmanim objects in the `__main__.py` example code by using the walrus operator (`:=`). This allows for a more concise and efficient check for the presence of zmanim before accessing their properties. The walrus operator improves readability and reduces code duplication by assigning and checking the zmanim object in a single expression. This change enhances the clarity and maintainability of the example code, making it easier for users to understand how to use the `JewCal` library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README examples have been updated to reflect the accurate zmanim times calculated using the Astral library. Astral provides more precise calculations for sunrise, sunset, and other zmanim, ensuring that the examples showcase the true capabilities of JewCal.