Make pattern_encoder feature less infectious#265
Open
Conversation
estk
reviewed
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whenever an appender is used this enables the
pattern_encoderfeature. This feature in turn pulls inchrono. This can be a bit frustrating for users if they are supplying their own appenders which use thetimecrate, and never make use ofPatternEncoder.This PR eliminates the dependence of the appender features on
pattern_encoder. I tried to make this as little of a breaking change as possible. Anyone using the default features will see no change to their code, and unless someone is using an appender without the pattern encoder feature then their code will also continue to compile. That being said, this is still technically a breaking change to the public API.I am open to suggestions regarding if/how the public API should be changed should this be accepted.