Skip to content

Add support for CompositeTrigger#342

Open
Dirreke wants to merge 2 commits intoestk:mainfrom
Dirreke:composite
Open

Add support for CompositeTrigger#342
Dirreke wants to merge 2 commits intoestk:mainfrom
Dirreke:composite

Conversation

@Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Jan 30, 2024

This is a BREAKING change.

This will support CompositeTriggerPolicy ([log4j]https://logging.apache.org/log4j/2.x/manual/filters.html#compositefilter).

It combines multiple triggering policies and returns true if any of the configured policies return true.


In addition, the following changes have been made.

  • Bump MSRV to 1.69.
  • Update examples log_to_file_with_rolling_file.

@Dirreke Dirreke requested review from estk and gadunga as code owners January 30, 2024 06:28
@Dirreke Dirreke marked this pull request as draft January 30, 2024 06:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c981ca4) 63.01% compared to head (bd31a6d) 62.96%.

Files Patch % Lines
src/append/rolling_file/policy/compound/mod.rs 40.00% 9 Missing ⚠️
...ppend/rolling_file/policy/compound/trigger/time.rs 89.47% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   63.01%   62.96%   -0.05%     
==========================================
  Files          24       24              
  Lines        1560     1577      +17     
==========================================
+ Hits          983      993      +10     
- Misses        577      584       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dirreke Dirreke marked this pull request as ready for review February 2, 2024 07:32
@Dirreke Dirreke force-pushed the composite branch 4 times, most recently from 9b5efc3 to 4ff1dc7 Compare February 2, 2024 09:45
@gauntl3t12
Copy link
Contributor

@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API

@Dirreke
Copy link
Contributor Author

Dirreke commented Feb 10, 2024

@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants