Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 63.01% 70.58% +7.57%
==========================================
Files 24 24
Lines 1560 1557 -3
==========================================
+ Hits 983 1099 +116
+ Misses 577 458 -119 ☔ View full report in Codecov by Sentry. |
| .tty_only(true) | ||
| .target(Target::Stderr) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
I've had recent experience where just creating the object would have discovered a bug causing segmentation faults. In that case it was the cleanup that occurs afterwards that caused the fault. Here we hit all aspects of the builder to ensure they don't enter an invalid state
|
|
||
| // No actions to take here, the writer becomes inaccessible but theres | ||
| // no getter to verify | ||
| logfile.roll(); |
There was a problem hiding this comment.
cant we verify the roll has happened?
There was a problem hiding this comment.
Hmm yeah, I can create a dummy LogWriter and make sure it gets cleaned up. It's a tough line of UTs without proper Mocks but that's a future addition.
3 participants
No description provided.