Draft: walletconnect support #52

ape-dev-cs · 2025-03-07T19:04:19Z

What it solves

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

vercel · 2025-03-07T19:04:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wallet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2025 3:55pm

github-actions · 2025-03-07T19:08:37Z

📦 Next.js Bundle Analysis for eternalsafe-wallet

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1.13 MB` (🔴 +399.57 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page	Size (compressed)	First Load
`/wallet-connect/transaction`	`47.38 KB`	1.18 MB

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/address-book`	`28.24 KB` (🟢 -120 B)	1.16 MB
`/balances`	`31.35 KB` (🟢 -5.44 KB)	1.16 MB
`/balances/nfts`	`28.54 KB` (🟢 -5.44 KB)	1.16 MB
`/new-safe/load`	`20.36 KB` (🟢 -2.05 KB)	1.15 MB
`/settings/appearance`	`3.63 KB` (🟢 -5.81 KB)	1.14 MB
`/settings/data`	`1.8 KB` (🟢 -5.81 KB)	1.13 MB
`/settings/environment-variables`	`4.69 KB` (🟢 -5.68 KB)	1.14 MB
`/settings/modules`	`3.36 KB` (🟢 -5.81 KB)	1.14 MB
`/settings/security-login`	`24.16 KB` (🟢 -5.81 KB)	1.16 MB
`/settings/setup`	`26.18 KB` (🟢 -5.81 KB)	1.16 MB
`/transactions`	`43.97 KB` (🟢 -5.98 KB)	1.17 MB
`/transactions/history`	`43.96 KB` (🟢 -5.98 KB)	1.17 MB
`/transactions/queue`	`43.96 KB` (🟢 -5.98 KB)	1.17 MB
`/transactions/tx`	`40.74 KB` (🟢 -175 B)	1.17 MB
`/welcome`	`4.77 KB` (🟡 +8 B)	1.14 MB
`/welcome/social-login`	`8.5 KB` (🟡 +4 B)	1.14 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2025-03-07T19:08:52Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	73.96% (-0.11% 🔻)	6171/8344
🔴	Branches	50.35% (+0.22% 🔼)	1365/2711
🔴	Functions	55.6% (-0.08% 🔻)	899/1617
🟡	Lines	76.05% (-0.1% 🔻)	5533/7275

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / settingsSlice.ts	45.59% (-5.32% 🔻)	28.57% (-21.43% 🔻)	29.17% (-5.83% 🔻)	44.23% (-4.55% 🔻)
🔴	src/utils/hex.ts	26.32% (-73.68% 🔻)	100%	33.33% (-66.67% 🔻)	23.08% (-76.92% 🔻)

Test suite run success

761 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 6808e5e

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/components/common/WalletConnectTransactionHandler/index.tsx

src/hooks/wallets/useWalletConnect.ts

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/components/common/WalletConnectPairingModal/index.tsx

src/components/common/WalletConnectTransactionHandler/index.tsx

src/hooks/wallets/useWalletConnect.ts

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/components/common/WalletConnectPairingModal/index.tsx

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/components/common/WalletConnectProvider/index.tsx

src/hooks/loadables/useLoadTxHistory.ts

src/hooks/wallets/useWalletConnect.ts

github-actions · 2025-05-12T17:05:16Z

src/hooks/wallets/useWalletConnect.ts

+    }
+
+    initWalletKit()
+  }, [projectId, isInitialized, isInitializing, pairingCode, setupEventListeners])


React Hook useEffect has a missing dependency: 'setWalletKitInstance'. Either include it or remove the dependency array. If 'setWalletKitInstance' changes too often, find the parent component that defines it and wrap that definition in useCallback. react-hooks/exhaustive-deps

Suggestion(s) available:

Suggested change

}, [projectId, isInitialized, isInitializing, pairingCode, setupEventListeners])

}, [projectId, isInitialized, isInitializing, pairingCode, setupEventListeners, setWalletKitInstance])

github-actions · 2025-05-12T17:05:17Z

src/hooks/wallets/useWalletConnect.ts

+        throw e
+      }
+    },
+    [isInitialized],


React Hook useCallback has a missing dependency: 'walletKitInstance'. Either include it or remove the dependency array. react-hooks/exhaustive-deps

Suggestion(s) available:

Suggested change

[isInitialized],

[isInitialized, walletKitInstance],

github-actions · 2025-05-12T17:05:17Z

src/hooks/wallets/useWalletConnect.ts

+        throw e
+      }
+    },
+    [isInitialized],


React Hook useCallback has a missing dependency: 'walletKitInstance'. Either include it or remove the dependency array. react-hooks/exhaustive-deps

Suggestion(s) available:

Suggested change

[isInitialized],

[isInitialized, walletKitInstance],

src/pages/wallet-connect/transaction.tsx

github-actions · 2025-05-12T17:05:18Z

src/pages/wallet-connect/transaction.tsx

+import SignOrExecuteForm from '@/components/tx/SignOrExecuteForm'
+import PageHeader from '@/components/common/PageHeader'
+import { AppRoutes } from '@/config/routes'
+import { TransactionDetails, TransactionInfoType } from '@safe-global/safe-gateway-typescript-sdk'


'TransactionInfoType' is defined but never used. unused-imports/no-unused-imports-ts

Fix available:

Suggested change

import { TransactionDetails, TransactionInfoType } from '@safe-global/safe-gateway-typescript-sdk'

import { TransactionDetails } from '@safe-global/safe-gateway-typescript-sdk'

github-actions · 2025-05-12T17:05:18Z

src/pages/wallet-connect/transaction.tsx

+    if (safeTx) {
+      extractTxDetails(safeAddress, safeTx, safe).then(setTxDetails)
+    }
+  }, [safeTx])


React Hook useEffect has missing dependencies: 'safe' and 'safeAddress'. Either include them or remove the dependency array. react-hooks/exhaustive-deps

Suggestion(s) available:

Suggested change

}, [safeTx])

}, [safe, safeAddress, safeTx])

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

Initial walletconnect modals/settings

84d48ef

vercel bot deployed to Preview March 7, 2025 19:08 View deployment

Walletconnect kind of works

313a3e7

github-actions bot requested changes Mar 7, 2025

View reviewed changes

ape-dev-cs added 2 commits March 7, 2025 23:41

Remove polyfills

89d8cb1

Prettier

5286633

github-actions bot requested changes Mar 7, 2025

View reviewed changes

vercel bot deployed to Preview March 7, 2025 23:50 View deployment

ape-dev-cs changed the title ~~Draft: Initial walletconnect modals/settings~~ Draft: walletconnect support Mar 7, 2025

walletconnect dailog -> page

bae343a

github-actions bot requested changes Mar 8, 2025

View reviewed changes

vercel bot deployed to Preview March 8, 2025 02:27 View deployment

Cleanup

73c4a83

github-actions bot requested changes Mar 8, 2025

View reviewed changes

vercel bot deployed to Preview March 8, 2025 04:15 View deployment

Use build-time API key if available

9b6db2f

github-actions bot requested changes Mar 8, 2025

View reviewed changes

vercel bot deployed to Preview March 8, 2025 21:19 View deployment

devanoneth requested changes Mar 8, 2025

View reviewed changes

update deps

28c0833

github-actions bot requested changes Mar 8, 2025

View reviewed changes

vercel bot had a problem deploying to Preview March 8, 2025 23:07 Failure

fix invalid UI states

9eb8d0c

github-actions bot requested changes Mar 8, 2025

View reviewed changes

vercel bot had a problem deploying to Preview March 8, 2025 23:17 Failure

devanoneth added 2 commits March 9, 2025 13:31

fix bignumber in tests

fe5bcb2

update TS, fix ESLint

d68f8a6

vercel bot deployed to Preview March 9, 2025 12:44 View deployment

PR comments

2c1ab13

vercel bot deployed to Preview March 9, 2025 14:05 View deployment

devanoneth reviewed Mar 9, 2025

View reviewed changes

src/components/common/WalletConnectPairingModal/index.tsx Outdated Show resolved Hide resolved

Update src/components/common/WalletConnectPairingModal/index.tsx

ddab51b

vercel bot deployed to Preview March 9, 2025 23:08 View deployment

ape-dev-cs marked this pull request as ready for review March 10, 2025 09:18

Fix settings

bccd416

vercel bot deployed to Preview March 10, 2025 16:55 View deployment

devanoneth added 2 commits March 10, 2025 19:43

walletconnect hook and provider fixes

8f5f711

some fixes, somethings still broken

23edeac

github-actions bot requested changes May 12, 2025

View reviewed changes

vercel bot had a problem deploying to Preview May 12, 2025 17:05 Failure

fix build

0469393

github-actions bot requested changes May 12, 2025

View reviewed changes

vercel bot deployed to Preview May 12, 2025 17:11 View deployment

cleanup comments and 'latest' block change

6808e5e

github-actions bot requested changes May 13, 2025

View reviewed changes

vercel bot deployed to Preview May 13, 2025 08:51 View deployment

Show value

be36142

vercel bot deployed to Preview May 21, 2025 20:47 View deployment

Eslint

94d0d62

vercel bot deployed to Preview May 24, 2025 15:55 View deployment

	}, [projectId, isInitialized, isInitializing, pairingCode, setupEventListeners])
	}, [projectId, isInitialized, isInitializing, pairingCode, setupEventListeners, setWalletKitInstance])

	import { TransactionDetails, TransactionInfoType } from '@safe-global/safe-gateway-typescript-sdk'
	import { TransactionDetails } from '@safe-global/safe-gateway-typescript-sdk'

Draft: walletconnect support #52

Are you sure you want to change the base?

Draft: walletconnect support #52

Uh oh!

Conversation

ape-dev-cs commented Mar 7, 2025

What it solves

How this PR fixes it

How to test it

Screenshots

Checklist

Uh oh!

vercel bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for eternalsafe-wallet

⚠️ Global Bundle Size Increased

New Page Added

Sixteen Pages Changed Size

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot May 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vercel bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading