-
Notifications
You must be signed in to change notification settings - Fork 47
Draft: Feat/transaction decoder #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ape-dev-cs
wants to merge
17
commits into
eternalsafe
Choose a base branch
from
feat/transaction-decoder
base: eternalsafe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage reportCaution Test run failed
Show files with reduced coverage 🔻
Test suite run failedFailed tests: 0/749. Failed suites: 3/120.Report generated by 🧪jest coverage report action from dc575ba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Does transaction name / parameter guessing locally based on a DB. Branches off of the walletconnect branch so that needs to go in first.
Resolves #
#20
How this PR fixes it
Has a database of files that map function signatures to function names, then uses ethers to decode them. Currently files are local on my machine, but will be stuck on IPFS at some point. Falls back to abi-guesser if it fails. Note this branch won't work locally until files are non-local and on IPFS.
How to test it
Connect walletconnect, send a TX, if it decodes the TX correctly
Screenshots
Checklist