Feat/safe creation #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oed is attempting to deploy a commit to the Eternal Safe Team on Vercel. A member of the Team first needs to authorize it. |
|
@devanoneth do you mind taking a look at this? We rely on this change to add support for Safe on our network |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PatrickAlphaC
pushed a commit
to PatrickAlphaC/eternalsafe
that referenced
this pull request
May 28, 2025
* Basic setup * Flow working * Fix test * update deps, create 1.4.1 safes and ensure it works on custom networks * update TS * update README env var section --------- Co-authored-by: Devan Non <devanon@chainstride.capital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2
How this PR fixes it
This PR re-enables the existing Safe creation flow. The main change done is that previously the address was calculated preemtively, however incorrectly. Instead this PR simply retrieves the safe address from the tx hash/receipt.
How to test it
Has been tested manually on Sepolia
Checklist