fix compatibility with radicale >= 3.5.9#362
Conversation
|
I could not find why this patch might be needed. Can you please provide an error message or something similar? EteSync DAV version: 0.35.1 |
|
Sure, sorry for not clarifying this earlier: The error happens when logging in locally: Since etesync doesn't do much with the newly added arguments (user_agent and remote_host), we can send empty strings instead. |
aktaboot
force-pushed
the
fix-radicale-3.5.9-compat
branch
3 times, most recently
from
fcb4a71 to
c470ff0
Compare
etesync_dav/radicale_main/server.py
Outdated
| return self._web.post(environ, base_prefix, path, user) | ||
|
|
||
| return super().do_POST(environ, base_prefix, path, user) | ||
| return super().do_POST(environ, base_prefix, path, user, "", "") |
There was a problem hiding this comment.
| return super().do_POST(environ, base_prefix, path, user, "", "") | |
| return super().do_POST(environ, base_prefix, path, user, remote_host, user_agent) |
Probably want that, right?
| @@ -53,13 +53,13 @@ | |||
|
|
|||
|
|
|||
| class MyApplication(Application): | |||
There was a problem hiding this comment.
Linting is failing, can you please fix it?
aktaboot
force-pushed
the
fix-radicale-3.5.9-compat
branch
from
c470ff0 to
b8ad61a
Compare
|
Thanks a lot! |
|
Thank you! and sorry for the small yet messy PR, |
3 participants
2 arguments were added for radicale server connections,
simple fix, mostly workaround by passing empty strings
relevant radicale commit:
Kozea/Radicale@1c7ff41