Update MIMIC IV to version 2.2#45
Closed
prockenschaub wants to merge 3 commits intoeth-mds:mainfrom
Closed
Conversation
Member
|
@prockenschaub This is a pure config change, so in terms of review comments, I don't have much to offer. Have you tried something like "loading all concepts from new mimic iv" to check compatibility of current concept definitions with the new data source definition? |
Member
|
The check CI failures seem unrelated. I'm happy to sort this out post-merge. |
Collaborator
Author
|
I ran all non-recursive concepts and the difference was a drop in 4-5% of rows across all concepts. This should be due to a reduction in patients for version 2.2. I didn't run recursive concepts because Sys.setenv(RICU_SRC_LOAD = "")
library(ricu)
# Get concepts
dict <- load_dictionary(src = "miiv")
# Get custom miiv config
cfg <- load_src_cfg(name = "miiv-1.0", cfg_dirs = "/path/to/miiv/versions")
attach_src(cfg$miiv, data_dir = "/path/to/miiv-1.0/data")
# Try to load a recursive concept
load_concepts(dict[["avpu"]], src = data$miiv)
#> • gcs
#> • egcs
#> • mgcs
#> • vgcs
#> • tgcs
#> • ett_gcs
#> Error in `assert_that()` at ricu-package/R/callback-cncpt.R:10:4:
#> ! length(dots) not identical to 1L
#> Run `rlang::last_trace()` to see where the error occurred.I nevertheless think this is a sufficient check and this can be merged now. |
This was
linked to
issues
Oct 11, 2023
Closed
Member
|
Solved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIMIC IV has introduced several changes to the data structure, including new tables and columns. This has lead to several issues for new users: #15 #28 #33 #42 #44
NOTE: this PR breaks backward compatibility with prior MIMIC IV versions. Fixing access to previous versions of the data is in process.