batman: redirect stderr to /dev/null when rendering preview#110
Open
Seas0 wants to merge 2 commits intoeth-p:masterfrom
Open
batman: redirect stderr to /dev/null when rendering preview#110Seas0 wants to merge 2 commits intoeth-p:masterfrom
Seas0 wants to merge 2 commits intoeth-p:masterfrom
Conversation
To avoid preview being flooded by garbage warnings.
Owner
|
Thanks for adding this! I'll need to add tests for a couple of scenarios1 before merging this, but it looks good code wise. 1 Mainly that it doesn't accidentally suppress legitimate warnings and errors. |
eth-p
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid preview being flooded by garbage warnings.