Fix batdiff not showing output when run from subdirectory#144
Open
davidbeesley wants to merge 1 commit intoeth-p:masterfrom
Open
Fix batdiff not showing output when run from subdirectory#144davidbeesley wants to merge 1 commit intoeth-p:masterfrom
davidbeesley wants to merge 1 commit intoeth-p:masterfrom
Conversation
When running batdiff from a subdirectory of a git repo, no output was shown. This happened because git diff --name-only returns paths relative to the repo root, but the file existence check was performed from the current directory. Fix by changing to the repo root after ensure_git_directory. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running batdiff from a subdirectory of a git repo, no output was shown. This happened because git diff --name-only returns paths relative to the repo root, but the file existence check was performed from the current directory.
Fix by changing to the repo root after ensure_git_directory.