Skip to content

Fix compilation errors in main.rs#3

Merged
ethanbissbort merged 1 commit intomainfrom
claude/rust-shell-script-migration-01LJ5PyVWrADv72dsKR9VqhM
Nov 15, 2025
Merged

Fix compilation errors in main.rs#3
ethanbissbort merged 1 commit intomainfrom
claude/rust-shell-script-migration-01LJ5PyVWrADv72dsKR9VqhM

Conversation

@ethanbissbort
Copy link
Owner

Fixed two compilation errors reported by GitHub CI:

  1. ModuleDescriptor field access errors (lines 162, 164):

    • Changed module.name() to module.name
    • Changed module.description() to module.description
    • ModuleDescriptor has fields, not methods
  2. Borrow of moved value error (line 153):

    • Changed 'for module in modules' to 'for module in &modules'
    • Prevents moving modules vector so it can be used later for .len()

Also cleaned up unused imports:

  • Removed unused cli::FluxCli import
  • Removed unused error::FluxError import

Build verified:

  • cargo check: ✅ No errors
  • cargo build --lib: ✅ Success
  • cargo build --bin flux: ✅ Success
  • Only warnings remain (unused imports in other files)

Fixed two compilation errors reported by GitHub CI:

1. ModuleDescriptor field access errors (lines 162, 164):
   - Changed module.name() to module.name
   - Changed module.description() to module.description
   - ModuleDescriptor has fields, not methods

2. Borrow of moved value error (line 153):
   - Changed 'for module in modules' to 'for module in &modules'
   - Prevents moving modules vector so it can be used later for .len()

Also cleaned up unused imports:
   - Removed unused cli::FluxCli import
   - Removed unused error::FluxError import

Build verified:
   - cargo check: ✅ No errors
   - cargo build --lib: ✅ Success
   - cargo build --bin flux: ✅ Success
   - Only warnings remain (unused imports in other files)
@ethanbissbort ethanbissbort merged commit 13b21ee into main Nov 15, 2025
1 check passed
@ethanbissbort ethanbissbort deleted the claude/rust-shell-script-migration-01LJ5PyVWrADv72dsKR9VqhM branch December 5, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants