Merged
Conversation
Fixed two compilation errors reported by GitHub CI: 1. ModuleDescriptor field access errors (lines 162, 164): - Changed module.name() to module.name - Changed module.description() to module.description - ModuleDescriptor has fields, not methods 2. Borrow of moved value error (line 153): - Changed 'for module in modules' to 'for module in &modules' - Prevents moving modules vector so it can be used later for .len() Also cleaned up unused imports: - Removed unused cli::FluxCli import - Removed unused error::FluxError import Build verified: - cargo check: ✅ No errors - cargo build --lib: ✅ Success - cargo build --bin flux: ✅ Success - Only warnings remain (unused imports in other files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two compilation errors reported by GitHub CI:
ModuleDescriptor field access errors (lines 162, 164):
Borrow of moved value error (line 153):
Also cleaned up unused imports:
Build verified: