fix: add runtime-aware sudo_prefix for Lima/macOS compatibility#17
Merged
ethannortharc merged 1 commit intomainfrom Mar 11, 2026
Merged
fix: add runtime-aware sudo_prefix for Lima/macOS compatibility#17ethannortharc merged 1 commit intomainfrom
ethannortharc merged 1 commit intomainfrom
Conversation
Previous PRs removed all sudo for Incus (which runs as root), but this broke Lima (macOS) where limactl shell runs as user and needs sudo for system operations. Added exec_runs_as_root() and sudo_prefix() to Runtime trait — Incus returns "" (already root), Lima returns "sudo ". All system commands now use sudo_prefix() + bash -lc for proper PATH. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec_runs_as_root()andsudo_prefix()methods to Runtime trait""(already root), Lima returns"sudo "(needs elevation)nixos-rebuild,mkdir /etc/...,mount,chown, etc.) now usesudo_prefix()+bash -lcfor proper PATHTest plan
cargo buildsucceedscargo test— all 67 tests passdevbox create --name test --tools godevbox destroy --name hive-dev && devbox create --name hive-dev --tools go🤖 Generated with Claude Code