fix: detect correct VM user on NixOS (skip nixbld)#22
Merged
ethannortharc merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Two bugs fixed: 1. Post-rebuild agent wait loop hardcoded `incus` commands instead of using the runtime abstraction. On Lima (macOS), this always failed, causing a 120s timeout on every create. 2. detect_vm_username/detect_vm_uid matched NixOS nixbld* users (UID 30001+ with home /var/empty) instead of the actual user. Now filters to users with home under /home/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime.exec_cmd()instead of hardcodedincus— fixes 120s timeout on every Lima (macOS) createdetect_vm_usernameanddetect_vm_uidnow filter to users with home under/home/— skips NixOSnixbld*users (UID 30001+ with home/var/empty)/var/empty/.zshrc: Operation not permittederrors on macOSTest plan
cargo build+cargo test— all 67 tests passethanovernixbld1in simulated /etc/passwddevbox createon macOS (Lima) — should detect correct user, no /var/empty errorsdevbox createon Linux (Incus) — should still work correctly🤖 Generated with Claude Code