Added support for custom unit decimals providing#244
Open
asimaranov wants to merge 3 commits intoethereum:mainfrom
Open
Added support for custom unit decimals providing#244asimaranov wants to merge 3 commits intoethereum:mainfrom
asimaranov wants to merge 3 commits intoethereum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
It's useful to be able to provide the custom unit decimals like
from_wei(123456789, 6). This is common practice in typescript API and handy when operating with token with decimals amount e.g.6is fetched from blockchainRelated to Issue # web3/web3.js#3169 for web3.js library
How was it fixed?
Added support for number passing to
from_wei,to_weithat is interpreted as decimals number.Todo:
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture
telegram-cloud-document-4-5983241381538172152.2.mp4