feat(mypy): proper decorator typing with ParamSpec#305
Open
BobTheBuidler wants to merge 3 commits intoethereum:mainfrom
Open
feat(mypy): proper decorator typing with ParamSpec#305BobTheBuidler wants to merge 3 commits intoethereum:mainfrom
BobTheBuidler wants to merge 3 commits intoethereum:mainfrom
Conversation
Contributor
Author
|
All tests will pass if you allow me to # type: ignore [misc] away these mypy errors, and typing will still work properly downstream. |
BobTheBuidler
changed the title
Contributor
Author
|
Alternatively, I'd like to suggest making typing_extensions a dependency so we can use ParamSpec appropriately on all python versions On second thought, I think this comment applies to the entire eth-xxx stack and could greatly improve typing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
More modern versions of python support ParamSpec in the typing module. This PR implements proper decorator typing with ParamSpec in all python versions that support it, and falls back to the current behavior on python versions that don't.
Related to Issue # N/A
Closes # N/A
How was it fixed?
Conditional definitions based on whether or not typing module has ParamSpec defined
Todo:
I did not update docs or release notes as I don't think its necessary for this type of change. Let me know if you disagree and I can do so.
Cute Animal Picture