Open
Conversation
yabirgb
commented
Aug 16, 2025
Comment on lines
+133
to
+134
| # is_hex_address already checks if it is_text | ||
| return is_hex_address(value) and bool(value == to_checksum_address(value)) |
Author
There was a problem hiding this comment.
here it removes a redundant function call
Comment on lines
-121
to
+110
| else: | ||
| return bool(to_normalized_address(left) == to_normalized_address(right)) | ||
|
|
||
| return to_normalized_address(left) == to_normalized_address(right) |
Author
There was a problem hiding this comment.
the cast is not needed here. Only when the argument has type Any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Parts of the code had redundant code
How was it fixed?
simplified the code while keeping the same checks. For the
to_checksum_addressfunction I tried to see if it was possible to improve its performance but I didn't manage to get anything meaninfulThis is reading and checksumming 10k addresses
Todo:
Cute Animal Picture