-
Notifications
You must be signed in to change notification settings - Fork 459
Update README with versioning information #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kclowes
wants to merge
1
commit into
ethereum:main
Choose a base branch
from
kclowes:readme-add-versioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -37,15 +37,15 @@ will have all schema `#ref`s resolved. | |||||
| #### Building the docs | ||||||
|
|
||||||
| Once you've updated something in the spec, you can use the docs generation tools | ||||||
| to view the updated specs locally. | ||||||
| to view the updated specs locally. | ||||||
|
|
||||||
| ```console | ||||||
| $ npm run build:docs | ||||||
| $ npm run watch | ||||||
| ``` | ||||||
|
|
||||||
| The `watch` command starts a local webserver serving the docs in-browser at | ||||||
| `http://0.0.0.0:8000` and it rebuilds when you update something in the specs. | ||||||
| The `watch` command starts a local webserver serving the docs in-browser at | ||||||
| `http://0.0.0.0:8000` and it rebuilds when you update something in the specs. | ||||||
| Please reload the page to see your changes. | ||||||
|
|
||||||
| ### Testing | ||||||
|
|
@@ -69,7 +69,7 @@ directory against the specification. There are two npm scripts to simplify this | |||||
|
|
||||||
| ```console | ||||||
| $ npm run build:test | ||||||
| $ npm run test | ||||||
| $ npm run test | ||||||
| all passing. | ||||||
| ``` | ||||||
|
|
||||||
|
|
@@ -129,6 +129,37 @@ A script is included in the source code which reads and validates the given sche | |||||
| $ npm run graphql:validate | ||||||
| ``` | ||||||
|
|
||||||
| ## Versioning | ||||||
|
|
||||||
| Execution-apis follows [semantic versioning][semver]. | ||||||
| - Major releases will include breaking changes to the [rpc-compat hive tests][rpc-compat], and other backwards incompatible changes. | ||||||
| - Minor releases will include new backwards-compatible features. | ||||||
| - Patch releases will include internal changes that don't impact end users and backwards-compatible bugfixes, along with fixing test cases that don't match the spec. | ||||||
|
|
||||||
| Examples of changes by version type: | ||||||
|
|
||||||
| **Major:** | ||||||
| - Adding new RPC methods | ||||||
| - Changing the parameters or return type of an existing method in an incompatible way | ||||||
| - Renaming fields in responses | ||||||
| - Changing error codes or error response structures | ||||||
| - Removing support for previously accepted input formats | ||||||
| - Adding new fields to response objects | ||||||
|
|
||||||
| **Minor:** | ||||||
| - Removing an existing RPC method | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - Adding optional parameters to existing methods | ||||||
| - Adding new error codes for previously uncovered edge cases | ||||||
| - Introducing new capabilities while maintaining backward compatibility | ||||||
|
|
||||||
| **Patch:** | ||||||
| - Fixing typos or improving clarity in documentation | ||||||
| - Correcting examples in the specification | ||||||
| - Fixing test cases that don't match the spec | ||||||
| - Improving validation rules without changing the API surface | ||||||
| - Updating internal tooling or build processes | ||||||
|
|
||||||
|
|
||||||
| ## License | ||||||
|
|
||||||
| This repository is licensed under [CC0](LICENSE). | ||||||
|
|
@@ -144,3 +175,4 @@ This repository is licensed under [CC0](LICENSE). | |||||
| [hive]: https://github.com/ethereum/hive | ||||||
| [rpc-compat]: https://github.com/ethereum/hive/tree/master/simulators/ethereum/rpc-compat | ||||||
| [test-gen]: docs/reference/tests.md | ||||||
| [semver]: https://semver.org/ | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.