Chat log sync to video/transcript + French support#93
Open
joshdavislight wants to merge 2 commits intoethereum:mainfrom
Open
Chat log sync to video/transcript + French support#93joshdavislight wants to merge 2 commits intoethereum:mainfrom
joshdavislight wants to merge 2 commits intoethereum:mainfrom
Conversation
Member
|
thanks for the PR - i actually removed chat log scroll sync recently because of how jumpy it is (and was requested by a couple users). ACD participants use the chat for long-running discussion in the background, so the latest messages frequently don't correspond to the discussion in the transcript. the french chat log support is welcome though, given zoom's dumb behavior of using multiple user system languages. |
Contributor
Author
|
Yeah, I gave that some thought in the way I designed the function, with the ability to unsync easily and resync with the button click, but understand if its an unwanted feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat Log Sync with Video Playback
In response to #78, Chat log now auto-scrolls to follow along with video playback, similar to how the transcript already works. When a user manually scrolls the chat, sync is paused and a "Sync" button appears to re-enable it. Seeking in the video (via player scrubber or clicking timestamps) also re-syncs the chat.
Additionally, added French language support for replies and reactions, as per #85