Skip to content

eth: unsubscribe from subscriptions on error to prevent leaks #32878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

eth: unsubscribe from subscriptions on error to prevent leaks #32878

wants to merge 6 commits into from

Conversation

@CertiK-Geth
Copy link
Contributor

Unsubscribe from active subscriptions when their parent error paths are hit to avoid leaking goroutines/subscriptions. Changes:

  • eth/filters/api.go: unsubscribe chain, header and logs subscriptions on error/exit paths.
  • eth/gasprice/gasprice.go: defer unsubscribing from chain head subscription.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CertiK-Geth @johnzhu0907