This repository was archived by the owner on Aug 8, 2018. It is now read-only.
Accept peers without DAO header and get rid of serpent#271
Open
hwwhww wants to merge 2 commits intoethereum:developfrom
Open
Accept peers without DAO header and get rid of serpent#271hwwhww wants to merge 2 commits intoethereum:developfrom
hwwhww wants to merge 2 commits intoethereum:developfrom
Conversation
Author
|
The travis CI failed at |
Member
|
I restarted it |
|
Changes Unknown when pulling e264119 on hwwhww:fix_dao_result into ** on ethereum:develop**. |
Author
|
@karalabe It passed! Thank you again! :) |
If the peer returns empty header list as the dao answer, it may be because the peer is not in Mainnet or the peer hasn't finished syncing yet.
hwwhww
force-pushed
the
fix_dao_result
branch
from
e264119 to
c912672
Compare
hwwhww
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @karalabe for finding this issue and giving advice.
If the peer returns empty header list as the dao answer, it may be because the peer is not in Mainnet or the peer hasn't finished syncing yet. This patch fixed it so that we can connect to geth node in private network.
The other commits are for passing CI (a bug of serpent). IMO it is messy now and it would be better to fix serpent or remove the serpent code in future PRs.