Updates to the attestation propagation sim #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seggregate nodes into Mesh Nodes, Mesh Attester Nodes and Non-mesh attester nodes.
bharath-123
commented
Oct 24, 2025
| case <-ctx.Done(): | ||
| return pubsub.ValidationReject | ||
| case <-time.After(100 * time.Millisecond): | ||
| // Timeout after 50ms (should be well within batch processing time) |
bharath-123
commented
Oct 24, 2025
Makefile
Outdated
Comment on lines
75
to
76
| uv run plot_propagation.py $(NODE_COUNT) --topology-file $(TOPOLOGY_FILE) --peer-count $(PEER_COUNT) --non-mesh-node-peer-count $(NON_MESH_NODE_PEER_COUNT) --batch-interval $(BATCH_INTERVAL) --batch-verifier-time $(BATCH_VERIFIER_TIME) -o plots/batch_$(BATCH_INTERVAL)ms_node$(NODE_COUNT)_mesh_nodes$(MESH_NODE_COUNT)_mesh_attesters$(MESH_ATTESTER_COUNT)_non_mesh_attesters$(NON_MESH_ATTESTER_COUNT).png | ||
| @test -f plots/batch_$(BATCH_INTERVAL)ms_node$(NODE_COUNT)_mesh_nodes$(MESH_NODE_COUNT)_mesh_attesters$(MESH_ATTESTER_COUNT)_non_mesh_attesters$(NON_MESH_ATTESTER_COUNT).png && echo "Plot generated: plots/batch_$(BATCH_INTERVAL)ms_node$(NODE_COUNT)_mesh_nodes$(MESH_NODE_COUNT)_mesh_attesters$(MESH_ATTESTER_COUNT)_non_mesh_attesters$(NON_MESH_ATTESTER_COUNT).png" || echo "Plot generation failed" |
Contributor
Author
There was a problem hiding this comment.
The names are a little long. Probably we could shorten them
bharath-123
commented
Oct 24, 2025
|
|
||
| # Build args with topology file | ||
| args = f"-node-id {i} -node-count {node_count} -msg-size {msg_size} -topology-file {topology_file}" | ||
| # Build args with topology file, nodes to publish, and batch parameters |
Implement a SlotTicker to keep track of runs
bharath-123
commented
Oct 28, 2025
| return | ||
| } | ||
|
|
||
| time.Sleep(bv.batchVerifierTime) |
Contributor
Author
There was a problem hiding this comment.
Instead of having a hard coded batch verifier time. It would be better to define the time taken per signature and multiply it with the batch size. That would be more accurate.
Split nodes by client types
updates to attsim
raulk
approved these changes
Nov 7, 2025
raulk
left a comment
raulk
left a comment
There was a problem hiding this comment.
Merging to review everything at once on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has logic to:
Mesh Nodes,Mesh Attester NodesandNon-Mesh Attester Nodes.Mesh Nodesare nodes which subscribe to the topic but do not publish.Mesh Attester Nodessubscribe to the topic and also publish messages.Non-Mesh Attester Nodesdo not subscribe to the topic but publish messages. Attsim uses nodeIds to give each node a unique ID. We reserve the first n IDs for the nMesh Nodes, The next k ids for the kMesh Attester Nodesand the remaining ids forNon-Mesh Attester Nodes.Non-Mesh Attester Nodesare only connected toMesh NodesandMesh Attester Nodeswith a degree which can be specified in theNON_MESH_NODE_PEER_COUNTflag in the Makefile.BATCH_INTERVALi.e how frequently the batch is flushed and verified andBATCH_VERIFIER_TIMEto define the time taken for the batch verifier to run. The BLS batch verification simulation is integrated into the async validator for the topic. When we receive a message for async validation, it is sent to the BLS batch verification simulator where it sits in a batch until it is flushed and the batch verifier runs(it just runs as a sleep in this case)Slotsimilar to an Ethereum slot. We use this to run the simulation for any given number of times.SimConfigfile to which we will eventually move all simulation parameters.