Conversation
… not use the same frame as rovio.
…imu message queue reached.
helenol
approved these changes
May 17, 2019
helenol
left a comment
helenol
left a comment
There was a problem hiding this comment.
Nice, LGTM! Interesting to see how Zec vs GTSAM will pan out.
|
|
||
| }; | ||
|
|
||
| class ZecImuIntegrator : ImuIntegrator { |
There was a problem hiding this comment.
Hahahahahahahaha this is amazing
@ZacharyTaylor your legacy lives on!!!
| << ". The current imu queue will be reset."); | ||
| << msg->header.stamp | ||
| << ". This is before the previously received IMU " | ||
| "message that ouccured at: " |
Author
There was a problem hiding this comment.
Also fixed the typo (I hope that is what you meant) 
michaelpantic
approved these changes
May 30, 2019
Member
michaelpantic
left a comment
michaelpantic
left a comment
There was a problem hiding this comment.
Won't look at code in detail as some of it is mine :-)
but LGTM
Maybe we should do a evaluation with VICON to compare ZEC :-) vs GTSAM (never got around to actually do it...)
Member
|
ah forgot about this: At the moment both integrators are running (for comparison). Before merging, I would add a rosparam to select the integrator and only run one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes: