Open
Conversation
Open
etnz
reviewed
Sep 2, 2022
Owner
etnz
left a comment
etnz
left a comment
There was a problem hiding this comment.
Thanks for the PR,
small changes and a curiosity question, other than that, it LGTM so I will very likely approve it after those changes
| func TestLit(t *testing.T) { | ||
| if !Lit(true).Is(true) { | ||
| if !Lit(true).isLiteral(true) { | ||
| t.Error("Lit(true).Is(true) must be true") |
Owner
There was a problem hiding this comment.
you need to adjust the error message
| } | ||
| if !Lit(false).Is(false) { | ||
| if !Lit(false).isLiteral(false) { | ||
| t.Error("Lit(false).Is(false) must be true") |
| //Is return true if this expression is equals to val | ||
| func (x expression) Is(val bool) bool { | ||
| // Is return true if this expression is equals to val | ||
| func (x Expr) isLiteral(val bool) bool { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously, this is a breaking change. In many applications, it will work with few changes. If compatibility is desired, it can be achieved at the expense of API clarity. Perhaps, it's a candidate for boole.
This exposes the underlying types of
expressionandmintermasExpr(replacing the interface) andTerm.This provides a machine readable way to see the state of the expression, enabling tools like the simplifier to be utilized as a library.