Fix kernel version check for TCP_FASTOPEN support #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#346
Description of the Change
TCP_FASTOPEN should be enabled based on the Linux kernel version. The current implementation is incorrectly evaluating some kernel versions and is failing to correctly handle minor version lower than 7 for major versions greater than 3.
For example, kernel versions 6.1 and 6.6 were incorrectly excluded, even though they do support TCP_FASTOPEN, just because its minor version is lower than 7.
Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
I have used GitHub search engine and git blame command line.
The first commit introducing this kernel version check was authored 10 years ago: a730551
The first commit suggests Kernel 3.6 to support TCP_FASTOPEN, but a newer commit change it to 3.7: 8786b2f
No more related commits.
Release Notes