Conversation
There was a problem hiding this comment.
Can these test cases be added as net-new test cases, rather than updating existing tests?
There was a problem hiding this comment.
I decided to clean it up a bit to remove a confusion and also added one new test for JSONPath case to the end of the file.
All of the tests call only one function json_handler.get_row_iterator which expects only one option (json_path) from the configuration. Table specs dict had excel config which is a bit confusing for json handler test, so I updated it, and regrouped specs and their related tests to make them more transparent. And I still missed "badnewlines" name of the first table spec (:
If you consider changes in old tests as a bad practise, I could rollback my changes and add new tests on top of the old ones.
There was a problem hiding this comment.
I've managed to build env with working dependencies and run tests. Some of the old tests don't work though, but it's not caused by the changes in this pull request and related to Excel-files.
There was a problem hiding this comment.
Clean test branch converted to poetry & GitHub workflow running test on different python versions committed here: https://github.com/TyShkan/tap-spreadsheets-anywhere/commits/poetry
|
Hello 👋 any update on when this might make it into main? This would be very useful for me! |
Closes #42
I struggled to run unittests due to dependencies conflicts, so I ran the test config with Meltano:
with some testing files included: test.zip