Support JSON dictionary along JSON files as input to the ArgoValidator#12
Merged
Support JSON dictionary along JSON files as input to the ArgoValidator#12
Conversation
Collaborator
|
Hi @gmaze, thanks for this. It's definitely a good idea to add in. I'll find some time in the next week to have a proper look through this and get it merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It would be very nice for cross-tools analysis if the
ArgoValidator().validate()method could take an dictionary object, not necessarily a json file.I propose here some update to the method to support this.
The use case would typically be when some sensor metadata will be loaded from a manufacturer API or any sensor metadata files with argopy to validate such data.
I also modified the init to be able to import the validator directly, such a nice feature needs the front row ;-)
PS:
What I have in mind here, is to be able to use
argo_metadata_validatorin argopy for internal format validation. Cf, ongoing work on sensors at: euroargodev/argopy#532.And since you support also float and platform schema, this should be used elsewhere in the future.