Draft
Conversation
- follows ADMT recommendation for vertical interpolation - add possibility to select pre-defined standard depth levels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADMT has recently endorsed a clean vertical interpolation procedure for T/S profiles.
The procedure is described in the EasyOneArgo data product specification and the interpolation method is based on "multiple Piecewise Cubic Hermite Interpolating Polynomials" as introduced by Barker and McDougall method, which is effective in avoiding the production of spurious water masses from interpolation of T and S separately.
The goal of this PR is to implement this new interpolation procedure in Argopy.
The current interpolation method is described here:
https://argopy.readthedocs.io/en/latest/user-guide/working-with-argo-data/data_manipulation.html#pressure-levels-interpolation
The current API is:
which relies on the
argopy.utils.linear_interpolation_remapfunction.The new API would use the xarray dataset extension design, and provides a new option to select the interpolation method:
To complete the EasyOneArgo integration, we could also add the possibility to provide a string instead of an array with pressure levels:
Rq: Update to BGC variables interpolation will be addressed in another PR
PR to-do list