Skip to content

Update config.js#21

Open
brp-magnusd wants to merge 1 commit intoevangalen:masterfrom
brp-magnusd:patch-1
Open

Update config.js#21
brp-magnusd wants to merge 1 commit intoevangalen:masterfrom
brp-magnusd:patch-1

Conversation

@brp-magnusd
Copy link
Copy Markdown

With the proposed change one could use the following to enable $qTick for all tests

beforeAll(function() {
ngImprovedTesting.config.$setQTickDefault(true);
})

and disable it on old tests that don't support $qTick with:

ngImprovedTesting.config.$qTickDisable();

With the proposed change one could use the following to enable $qTick for all tests

```
beforeAll(function() {
ngImprovedTesting.config.$setQTickDefault(true);
})
```

and disable it on old tests that don't support $qTick with:

`ngImprovedTesting.config.$qTickDisable();`
@evangalen
Copy link
Copy Markdown
Owner

Thank you for pull request.
I really like the idea of being able to turn on $qTick by default and to allow disabling it for particular tests.
Prior to merging your pull request I would to take some time to think it through.
This Monday night I finally have some time to spare... and most likely will create a new release with your pull request (which I might alter a little since I prefer not to use flags if possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants