Fix OpenAPI generator crash on empty content objects#362
Merged
Conversation
…odies
Guard against content: {} in OpenAPI spec responses and request bodies
which caused TypeError crashes when Object.keys() returned an empty array.
Closes #2346
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: fead971 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2346
What This PR Does
Fixes a crash in the OpenAPI generator when responses or request bodies have
content: {}(an empty content object). This is valid OpenAPI but caused aTypeErrorbecauseObject.keys({})returns an empty array, and accessing[0]yieldsundefined. The generator now gracefully skips empty content objects while still processing valid ones.Changes Overview
Key Changes
getSchemasByOperationId(request body and response schema extraction)getExamplesByOperationId(request body and response example extraction)content: {}on responses and request bodiesHow It Works
The fix adds
if (contentType)checks afterObject.keys(content)[0]at all 4 locations where content types are extracted. Whencontentis an empty object, the code now skips that response/request body instead of crashing. Valid responses with actual content types continue to be processed normally.Breaking Changes
None
Additional Notes
The reporter's second concern (one failing generator stopping all subsequent generators) is handled at the EventCatalog core orchestration level, not in this generator package. The fix here prevents the crash from occurring in the first place.
🤖 Generated with Claude Code