feat(generators): support generating services into subdomain paths#366
Merged
feat(generators): support generating services into subdomain paths#366
Conversation
All generators now use getResourcePath to resolve the actual domain
location on disk instead of hardcoding domains/{id}/services. This
enables nested subdomain paths like
domains/Buyer/subdomains/Agency/services/MyService.
Updated SDK to 2.18.2 which preserves subdomain paths when adding
resources to domains.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e87d4a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getResourcePathinstead of hardcoded domain paths, enabling nested subdomain paths likedomains/Buyer/subdomains/Agency/services/MyService2.18.2across all generator packages (includes subdomain path preservation fix)What This PR Does
All generators previously hardcoded service paths as
domains/{id}/services/{serviceId}, which meant services could only be generated at the top-level domain. This updates all generators to dynamically resolve domain locations usinggetResourcePathfrom the SDK.How It Works
getResourcePath(catalogDir, domainId, domainVersion)to find where the domain actually lives on diskdomains/Buyer/subdomains/Agency), the service path is constructed relative to that locationdomains/{id}behavior for backward compatibilityBreaking Changes
None. Existing catalogs with top-level domains continue to work unchanged.
Test plan
Depends on SDK
2.18.2(event-catalog/eventcatalog#2359, event-catalog/eventcatalog#2361)🤖 Generated with Claude Code