Skip to content

Conversation

@lautaro-eb
Copy link

@lautaro-eb lautaro-eb commented Oct 10, 2019

Adding pointer to extra key error dictionary field.
This will prevent not clear messages, for instance at the API level.

Needed Request Schema

{
    "performer": {
        "artist_id": 2
    }
}

Realized request

{
    "performer": {
        "artist_id": 2,
        "not_known_field": 12
    }
}

Response

{
    "status_code": 400,
    "error_description": "There are errors with your arguments: performer - UNKNOWN",
    "error": "ARGUMENTS_ERROR"
}

Expected response

{
    "status_code": 400,
    "error_description": "There are errors with your arguments: performer.not_known_field - UNKNOWN",
    "error": "ARGUMENTS_ERROR"
}

@lautaro-eb lautaro-eb changed the title [MINOR] EB-124910 Adding pointer to extra key error dictionary field [PATCH] EB-124910 Adding pointer to extra key error dictionary field Oct 10, 2019
Copy link
Contributor

@nickwilliams-eventbrite nickwilliams-eventbrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a temporary hold on this while we discuss on Slack.

Copy link
Contributor

@vartec vartec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backwards incompatible change, and as such should be considered [MAJOR]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants