Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the TypeScript type safety for the EventDBX Node.js client by introducing strongly-typed enums for PayloadMode and Priority, along with formal type definitions for JSON-related types (JsonValue, JsonPatch variants). The changes also refactor inline validation logic into reusable functions (normalize_payload_mode and normalize_priority), improving code maintainability.
- Adds
PayloadModeandPriorityenums with TypeScript definitions and exports - Introduces
JsonValueandJsonPatchtype definitions for better type safety - Refactors validation logic into dedicated normalization functions
- Updates version from 1.4.3 to 1.4.4
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds PayloadMode and Priority enums with string_enum support, defines JsonValue and JsonPatch types, and refactors inline validation into normalize_payload_mode and normalize_priority functions |
| index.d.ts | Adds TypeScript type definitions for JsonValue, JsonPatch variants, PayloadMode and Priority enums; updates interface properties to use strongly-typed enums instead of plain strings |
| index.js | Exports PayloadMode and Priority enums to make them available to JavaScript consumers |
| eventdbx.wasi.cjs | Exports PayloadMode and Priority enums for WASI CommonJS module |
| eventdbx.wasi-browser.js | Exports PayloadMode and Priority enums for WASI browser module |
| package.json | Bumps version to 1.4.4 |
| Cargo.toml | Bumps version to 1.4.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.