Add support for flattening the hostname component of metrics. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converts the hostname into one single graphite metric component. In our case we do not use the components of the host fqdn as part of the metric tree. Instead, the fqdn is a single component with dots replaced by underscores. e.g. foo.example.com becomes foo_example_com. This commit adds support for this but leaves it turned off by default. It also adds the missing parameter docs to the class header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a new parameter
graphite_flatten_hostnamethat converts the hostname into one single graphite metric component.In our case we do not use the components of the host fqdn as part of the
metric tree. Instead, the fqdn is a single component with dots replaced
by underscores. e.g. foo.example.com becomes foo_example_com.
This commit adds support for this but leaves it turned off by default.
It also adds the missing parameter docs to the class header.