feat(vfs): lazy file content loading for InMemoryFs#923
Merged
Conversation
Add LazyFile variant to FsEntry that defers content loading until first read. stat() returns metadata without triggering the load. If a lazy file is overwritten before being read, the loader is never called. Adds add_lazy_file() on InMemoryFs and mount_lazy() on BashBuilder. Includes 4 unit tests covering read, write-before-read, exists/readdir, and snapshot materialization. Closes #912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LazyFilevariant toFsEntry— defers content loading until firstread_file()stat()returns metadata without triggering the loadsnapshot()materializes all lazy files before capturingInMemoryFs::add_lazy_file()andBashBuilder::mount_lazy()Test plan
test_lazy_file_read— stat doesn't load, read doestest_lazy_file_write_before_read_skips_loader— write replaces lazy entrytest_lazy_file_exists_and_readdir— lazy files appear in listingstest_lazy_file_snapshot_materializes— snapshot forces loadCloses #912