Bye ESI versions, Hello compatibility date - services edition#185
Merged
Crypta-Eve merged 4 commits intoeveseat:masterfrom Oct 9, 2025
Merged
Bye ESI versions, Hello compatibility date - services edition#185Crypta-Eve merged 4 commits intoeveseat:masterfrom
Crypta-Eve merged 4 commits intoeveseat:masterfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESI no longer uses versions in the endpoint URL, and as of right now, they also have no effect. See https://developers.eveonline.com/blog/changing-versions-v42-was-getting-out-of-hand. Instead, there are now compatibility dates.
This PR removes endpoint versions from the EsiClient interface, but also introduces support for the compatibility date headers. This is a breaking change. However, I do think it is unavoidable because eveapi always operates on EsiClients and has no way of accessing the underlying Eseye instace. I don't think it is likely that there are any EsiClient implementations besides the eveapi one, so we are probably fine.
Must be released at the same time as eveseat/eveapi#438